Raw List of Smoke Changes

A list of tiny, probably significant code changes in the Smoke source

I recommend using your browser's search function when it starts to get large and ugly.

Remember that "--~~~~" is how to put in your signature

• BaseTypes/MathX.h: changed intrin.h to xmmintrin.h --Leemasa 01:00, 26 February 2010 (UTC)
• Framework/EnvironmentManager.cpp: deleted windows.h --Leemasa 03:18, 24 February 2010 (UTC)
• BaseTypes/DataTypes.h: deleted W64SAFE in front of type declaration --Leemasa 03:18, 24 February 2010 (UTC)
• BaseTypes/Math.h: deleted microsoft-specific "declspec" function x2 --Leemasa 03:27, 24 February 2010 (UTC)
  • This was mis-typed earlier as "deleted math.h" --Leemasa 21:03, 25 February 2010 (UTC)
• BaseTypes/Math.h: deleted extra qualification ‘Matrix4x4::’ on member ‘Inverse’ --Leemasa 21:08, 25 February 2010 (UTC)
• __m128 is defined in Linux's xmmintrin.h library, but requires a special kernel patch to work. --Leemasa 01:00, 26 February 2010 (UTC)
  • The entire MathX.h library is built around this, so I'm commenting that library out for now --Leemasa 01:44, 26 February 2010 (UTC)
    • The solution! No kernel patch required. In the Makefile, added -sse2 flag. Now xmmintrin is successful --Leemasa 15:54, 28 February 2010 (UTC)
• BaseTypes/Math.h: Changed all V++'s __forceinline s to __inline__s --Leemasa 01:20, 26 February 2010 (UTC)
• BaseTypes/MathX.h: changed windows-specific _aligned_malloc to posix_memalign, and _aligned_free to free.--Leemasa 22:15, 4 March 2010 (UTC)
• BaseTypes/MathX.h: UNREFERENCE_PARAM(a) removed--Leemasa 22:15, 4 March 2010 (UTC)
• Removed #pragma warning from Math.h, ArrayList.h, and RedBlackTree.h--Leemasa 22:15, 4 March 2010 (UTC)
• BaseTypes/RedBlackTree.h: Removed all the NodeColor:: specifiers from the Red, Black enums--Leemasa 22:15, 4 March 2010 (UTC)
• BaseTypes/List.h: Changed a few cases of code that couldn't possibly compile on any sane compiler, and marked them with the secret handshake
  • For example:

\\before
Iterator( TListNode* pListNode=NULL ) : m_pListNode( p )
{}
\\after
Iterator( TListNode* pListNode=NULL ) : m_pListNode( pListNode )
{}

• Also, in one function a variable was declared pNode. This variable was never accessed in the entire function, which instead referred to pTempNode. I changed the declaration of pNode to pTempNode.--Leemasa 22:25, 4 March 2010 (UTC)
• BaseTypes/List.h: List<T>::Iterator It, trying to declare an Iterator as defined in a variable "List" rather than as defined in the class "TList". Changed to TList<T>::Iterator. How an error like this slipped through the original code is beyond me.--Leemasa 19:25, 5 March 2010 (UTC)